search

chunky-dev / chunky

A path tracer to create realistic images of your Minecraft worlds.
https://chunky-dev.github.io/docs
GNU General Public License v3.0
653 stars 77 forks source link

Changing canvas size sometimes does not resize the preview window #27

Open llbit opened 11 years ago

llbit commented 11 years ago

Sometime changing the canvas size does not work as intended. For example the double canvas size button may not work, and it does not work to increase the canvas size in large increments.

llbit commented 11 years ago

TODO: Check if there is a way to force Swing to resize the preview window?

Coestar commented 11 years ago

I have found that with some scenes, I simply cannot change the canvas size - I push the button and nothing happens. When this happens, it also doesn't save the new numbers. If I set the canvas size I want as default, then the scenes that don't work simply won't open at all. Chunky provides no feedback on what's happening, seems to just silently fail. I would prefer to be able to set the size regardless of whether Chunky can actually display it or not, as I am doing my rendering remotely (headless). A command-line override would be lovely.

abonander commented 10 years ago

Has this been fixed by our patch for the blank preview window?

Jolyk commented 10 years ago

I set size to 1920x1080 -> ok. I press "double" -> 3840x2160 -> preview turned to white, but render ok. I press "double" again -> resolution did not change -> still white, didn't try to render.

(i heard something about 4k bitmap limitaion on direct2d)

win 8.1 64bit java 7 upd 55 32bit chunky 1.2.2

IceSelkie commented 3 years ago

This is caused by JavaFX canvas size being too large: #492

This will also be (pretty much) fixed, as soon as #786 is complete.

(Could we possibly mark this as duplicate and close this to use #492 issue thread instead?)

IceSelkie commented 3 years ago

~This is caused by JavaFX canvas size being too large: #492~

~This will also be (pretty much) fixed, as soon as #786 is complete.~

~(Could we possibly mark this as duplicate and close this to use #492 issue thread instead?)~

Woops, actually, this issue is unique from #492 as 492 discusses larger canvases that exceed Integer#MAX_VALUE / 3 in pixel count, not canvases which are smaller and still cause JavaFx to fail silently, like #314 did.

See: https://github.com/chunky-dev/chunky/pull/786#issuecomment-773684014