chuntaro / emacs-keypression

Keystroke visualizer for GUI version Emacs.
122 stars 4 forks source link

Leaves around stale child-frames? and needs turning off before main frame can be killed #19

Open unhammer opened 3 years ago

unhammer commented 3 years ago

After using for a while, I get a bunch of "untitled windows" from Emacs in my task bar.

Also, if manually exiting these before turning off keypression-mode, it won't let you exit the main frame:

Error in pre-command-hook (keypression--pre-command): (error "#<dead frame  0x5650e191ac40> is not a live frame")
handle-delete-frame: Attempt to delete a surrogate minibuffer frame
TentativeConvert commented 3 years ago

I also get the error Attempt to delete a surrogate minibuffer frame when keypression-mode is active and I try to close Emacs with the mouse (using title bar button).

psionic-k commented 11 months ago

I don't get this issue with champagne. I might have to re-use that work in my command log package. I'll look at the implementation tomorrow.

psionic-k commented 10 months ago

I was able to see this issue and that #20 fixed it by adding frame parameters