Open chunzkok opened 1 year ago
Our app is not made to be ran in parallel
Team chose [response.NotInScope
]
Reason for disagreement:
Although it is true that this is less important than the other work that has been done by the team, according to the course website, one of the two conditions must be satisfied for a bug to be considered not in scope.
However, the first condition does not hold as it is not stated in the User Guide that the app should not be used in parallel.
The second condition also does not hold as using the app in parallel does lead to unexpected behaviour (data loss).
Environment: MacOS Ventura 13.2.1, Apple M1, Java 11 Zulu
Description: When two instances of
GoodMatch
are open at the same time, it is possible to have inconsistencies in the data.How to reproduce:
java -jar
. Let us refer to the instance of GoodMatch that is opened by this command asGM1
.java -jar
. Let us refer to the instance of GoodMatch that is opened by this command asGM2
.GM1
, enter the commandadd t/McDonalds Cashier d/Count money
.GM2
, enter the commandadd t/KFC Cashier d/Count money
.GM1
andGM2
, enter the commandview
to try to obtain the list of all job listings.Expected behavior: Both instances
GM1
andGM2
should contain the two newly added job listings titledKFC Cashier
andMcDonalds Cashier
.Observed behavior: Both instances only contain either one of
McDonalds Cashier
orKFC Cashier
, but not both. After closing both instances and reopening them, onlyKFC Cashier
remains (see the screenshot for GM2)Shown above: GM1
Shown above: GM2
Remarks: This scenario may be unlikely to happen, but it is still possible for a user to accidentally open two instances of the same app when they are unaware that another instance is already running. This data loss may not be a big issue if the user realises early, but if the user only realises it after adding a lot of data to only one instance, quite a lot of data may be lost.