chunzkok / pe

0 stars 0 forks source link

Duplicate app instances cause inconsistency in data storage #4

Open chunzkok opened 1 year ago

chunzkok commented 1 year ago

Environment: MacOS Ventura 13.2.1, Apple M1, Java 11 Zulu

Description: When two instances of GoodMatch are open at the same time, it is possible to have inconsistencies in the data.

How to reproduce:

Expected behavior: Both instances GM1 and GM2 should contain the two newly added job listings titled KFC Cashier and McDonalds Cashier.

Observed behavior: Both instances only contain either one of McDonalds Cashier or KFC Cashier, but not both. After closing both instances and reopening them, only KFC Cashier remains (see the screenshot for GM2)

Screenshot 2023-04-14 at 2.52.25 PM.png Shown above: GM1

Screenshot 2023-04-14 at 2.52.57 PM.png Shown above: GM2

Remarks: This scenario may be unlikely to happen, but it is still possible for a user to accidentally open two instances of the same app when they are unaware that another instance is already running. This data loss may not be a big issue if the user realises early, but if the user only realises it after adding a lot of data to only one instance, quite a lot of data may be lost.

soc-pe-bot commented 1 year ago

Team's Response

Our app is not made to be ran in parallel

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: image.png

Although it is true that this is less important than the other work that has been done by the team, according to the course website, one of the two conditions must be satisfied for a bug to be considered not in scope.

However, the first condition does not hold as it is not stated in the User Guide that the app should not be used in parallel.

The second condition also does not hold as using the app in parallel does lead to unexpected behaviour (data loss).