chunzkok / pe

0 stars 0 forks source link

Error message for undo could provide more information #5

Open chunzkok opened 1 year ago

chunzkok commented 1 year ago

Environment: MacOS Ventura 13.2.1, Apple M1, Java 11 Zulu

Description: When trying to undo a command as the very first command entered since the application was opened, an error message appears but there is no description of why an error occurred.

How to reproduce:

Expected behavior: An error message indicating that there are no commands to roll back

Observed behavior: Screenshot 2023-04-14 at 2.58.17 PM.png

Remarks: unlikely for this to actually occur unless the user has severe short term memory, but might be good to let user know exactly why the undo command failed

soc-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Image missing from UG undo command

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


The undo error message image is not rendered

image.png


[original: nus-cs2103-AY2223S2/pe-interim#4590] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This bug is accepted, however, I believe it does not affect usage as the error message is displayed when the user uses the app. The user guide also already mentions the presents of it just not the exact message.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: image.png

According to the course website, a bug can be considered a duplicate of another if any of the two conditions are met.

The first condition is not satisfied as one is regarding a broken image link in the user guide whereas the other is regarding an error message during app operation itself.

The second condition is also not satisfied as both issues can be resolved independently of each other, since the issue arises from two different areas (User Guide vs Application)


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** (want to change to `type.FeatureFlaw`) This issue is about the error message during actual operation of the app, instead of a missing image link in the user guide. Nonetheless, this should be considered a Feature Flaw instead as the app still works as expected.