search

churchers / vm-bhyve

Shell based, minimal dependency bhyve manager
BSD 2-Clause "Simplified" License
840 stars 181 forks source link

vm-migrate typo (easy fix) #481

Closed Duncan-Young closed 2 years ago

Duncan-Young commented 2 years ago

line 154: kill -0 ${_pid} >/dev/null 2>&1 && util:err_inline "failed to stop guest"

needs to have "util:err_inline" replaced with "util::err_inline" i.e. one ":" was accidentally left out.

Duncan-Young commented 2 years ago

Just found a couple more. To stop the bhyve instance, I believe -15 (TERM) is required (the default) rather than -0.

so vm-migrate: 145 & 154 need: kill -0 ${_pid} >/dev/null changed to kill ${_pid} >/dev/null

Duncan-Young commented 2 years ago

Changed to a pull request