churchers / vm-bhyve

Shell based, minimal dependency bhyve manager
BSD 2-Clause "Simplified" License
840 stars 181 forks source link

netgraph node naming? #491

Open bellhyve opened 2 years ago

bellhyve commented 2 years ago

Awesome that 1.5 brought us netgraph support! I got so excited I wrote a tool to help bridge vm-bhyve VMs and jails and a little stat viewer and stuff.

I think a good next step would be to rename the netgraph node. Pretty sure all we'd need to do is do a quick character sanity check (tr the dots, etc.) and then ngctl name public:linkX vm_name. Is this on someone's to-do list, or should I submit a PR? Is there any reason why this wouldn't be desirable? Thanks!