search

churchthemes / church-theme-content

The Church Content WordPress plugin provides compatible themes with church-related post types, taxonomies and custom fields.
https://churchthemes.com/plugins/church-content/
GNU General Public License v2.0
58 stars 27 forks source link

Add video enclosure for podcast feed #25

Closed mintplugins closed 3 years ago

mintplugins commented 3 years ago

This PR adds video enclosure support for podcasting, if a valid video URL has been set.

stevengliebe commented 3 years ago

Hey Phil, this is not in my plans for CC/CCP so I think your best bet might be to run your code on the ctc_correct_sermon or ctc_after_save_sermon action right after ctc_do_enclose is triggered.

mintplugins commented 3 years ago

Hey Steven,

Thanks for the response. I'll look at doing that. Any reason this isn't part of your plans?

stevengliebe commented 3 years ago

Demand for video podcasting has been nearly zero and I'm turning my attention towards WP Sermons as far as sermon features go. WP Sermons will have video podcasting not so much as necessity but as icing on the cake.

mintplugins commented 3 years ago

@stevengliebe I have had requests for it, and since the PR is done and works, is there any reason not to merge it aside from it being icing in that other (competing?) plugin? I don't see it being a maintenance burden as its pretty simple, and since videos are an option built into this plugin, it makes sense they would work just like audio files.

mintplugins commented 3 years ago

That being said, if you do see this as a big maintenance burden for a reason I haven't considered, I definitely respect your decision. I just want to understand why its being denied more fully.

stevengliebe commented 3 years ago

I'd need to spend time looking into the implications (I believe there may be several) but don't have time. With WP Sermons coming, advancing CC is not a priority (maintaining it indefinitely is). I think you should be able to accomplish what you want with hooks.