search

churchthemes / church-theme-content

The Church Content WordPress plugin provides compatible themes with church-related post types, taxonomies and custom fields.
https://churchthemes.com/plugins/church-content/
GNU General Public License v2.0
58 stars 27 forks source link

Reason for &$this references? #8

Closed davidshq closed 9 years ago

davidshq commented 9 years ago

Wondering if there is a reason for retaining &$this references in code (e.g. church-theme-content.php under __construct)?

stevengliebe commented 9 years ago

You're right, & shouldn't be necessary. Do you want to submit a pull request to get credit? Or I can just remove 'em if you don't have the time.

davidshq commented 9 years ago

Sure, I'll submit a pull request momentarily. I'm just getting going on GitHub, so I'll take the credit where I can get it. ;-)

On Fri, Jul 31, 2015 at 12:48 PM, Steven Gliebe notifications@github.com wrote:

You're right, & shouldn't be necessary. Do you want to submit a pull request to get credit? Or I can just remove 'em if you don't have the time.

— Reply to this email directly or view it on GitHub https://github.com/churchthemes/church-theme-content/issues/8#issuecomment-126749810 .

stevengliebe commented 9 years ago

Thanks for the contribution, included with 1.3.3.

https://github.com/churchthemes/church-theme-content/releases/tag/1.3.3