search

churchtools / changelogger

CLI Tool for creating consistent and committable changelog entries.
https://churchtools.github.io/changelogger/
Apache License 2.0
32 stars 9 forks source link

Move changelogger type to config #27

Closed cwandrey closed 4 years ago

cwandrey commented 4 years ago

I once tried to turn the Types into a config. But the config/changelogger.php seemed to make most sense.

obstschale commented 4 years ago

Thx for your PR. Few points.

  1. The tests are failing. Please take a look at them.
  2. The string types in config/changelogger.php is in my eyes not good. Because if you use changelogger as PHAR you cannot take a look at the php file. So a list of all available types should be printed.
  3. You moved the $types array to config/ but they are not using the .env. Use the env() method and pass the types as default parameter.