search

churchtools / changelogger

CLI Tool for creating consistent and committable changelog entries.
https://churchtools.github.io/changelogger/
Apache License 2.0
32 stars 9 forks source link

PHP 8 compatibility #49

Closed MaPePeR closed 2 years ago

MaPePeR commented 3 years ago

Because of the php requirement in composer.json this tool cannot be used in PHP8 at the moment:

  "require": {
    "php": "^7.2.5",
    "ext-json": "*"
},

I cloned the repository, changed the php requirement to ^7.2.5|^8.0, did a composer update and ran the tests using composer test and all of them were successful. The ./changelogger script also seems to work fine, so I assume the composer.json is the only problem.

I could trick my project to install changelogger as a dependency, but because of the runtime checks the program refuses to run on PHP8.

Sadly I don't know how to properly build this project, so I'm not comfortable doing a pull request.

obstschale commented 2 years ago

I will take a look and make it php8 compatible

strausmann commented 2 years ago

+1

obstschale commented 2 years ago

Next version will support php7.4, 8.0