search

churchtools / churchtools_basic

ChurchTools 2.0 - Basis-Version
www.churchtools.de
MIT License
15 stars 20 forks source link

one more fix on #4 prepare_sources.sh dos not work if the path contains ... #5

Closed bwl21 closed 10 years ago

bwl21 commented 10 years ago

UTILS_PATH was wrong, so it could not find js_compiler.jar

isbm commented 10 years ago

No, this is a wrong fix, which now resolving to "utils/utils" and the compiler is now actually fails. The utility is not meant to be run within the "utils" directory.

bwl21 commented 10 years ago

I see, but in this case, wouldn't it be worth to see if the utility is started from the correct folder and provide an appropriate message to the user.

An even better way would be to compute the path out of the absolute path of the script and not to rely on the current working directory.

BTW: in my fork, I have setup a ruby/rake task which generates the API-Doc. I could provide more rake tasks for the regular maintenance routines if you wish. Rake provides much more power to setup build and maintenance environments than sh or even make.

isbm commented 10 years ago

Patch for it? :) I've tossed up this code per few minutes to make the packages. Of course, if you wish it better, go ahead pull request. :)

Ruby: something to discuss at https://groups.google.com/forum/#!forum/churchtools