chusiang / mysql-master-master

Automatically exported from code.google.com/p/mysql-master-master
GNU General Public License v2.0
1 stars 1 forks source link

settings from config file should ignore trailing whitespace #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Include an innocent looking blank space at the end of a config file value - 
say an ip address in 
mmm_lvm.conf
2. Attempt to use an mmm feature that uses that value to form a larger command 
- say 
mmm_backup
3. Watch the command fail to execute because "backup@192.168.0.2 :/backup" has 
a space after 
the IP address

What is the expected output? What do you see instead?
Trailing white space should be ignored.  This could be checked for in every 
single feature and 
tool.  A better solution might be to have them be removed by the config file 
reading methods.

What version of the product are you using? On what operating system?
mmm-1.0 rev 93 from trunk.

Please provide any additional information below.

Attached is a patch to config.pm which removes trailing whitespace from config 
files ... it will 
remove blank lines as well.

Original issue reported on code.google.com by batal...@gmail.com on 11 Sep 2008 at 11:35

Attachments:

GoogleCodeExporter commented 9 years ago
Applied the patch, thanks!

Original comment by kovy...@gmail.com on 4 Oct 2008 at 8:39