Closed glyphical closed 7 months ago
hello, i will take a look of this PR, hang on
I addressed all the comments that I could. I do recommend re-integrating the minimap mod information, but otherwise it should be prepared for use now.
OK now it's ready, missed the lightswitch issue.
we don't want to criticize another mod unless it does make the game environment more terrible, we more like to send feedback to mini-map mod author to fix those problem instead add opinions in the mod; And the host should have more experience, not the mod to teach them
I wouldn't say there was any criticism of the mod in my message--it simply said what minimaps do in completely neutral terms. Still I suppose I understand.
but still u can add opinions in config, just don't add it in message
Oh I understand now. I didn't want to keep the minimap info in the detection message, I only wanted to keep the info on what minimaps do in the config as I definitely understand removing the 'makes loot easier to find' thing. I already removed it though, it's no big deal--overall, you should be good to go with this now.
will notify mod author, and i may have to modify some readme-en, thx for ur translation!
Is everything ready?
It's prepared for merging as far as I can tell.
Just reviewed the text again and it's looking good. No typos that I saw. Should be good to go.
If I'm doing this correctly, this branch contains a total English retranslation of the mod to give it perfect English in a consistent, professional style. In many cases, text was shortened and made easier to understand for end users. I realized I did the brackets wrong in the translation file I provided previously, so that has been fixed.