search

chvancooten / CloudLabsAD

Terraform + Ansible deployment scripts for an Active Directory lab environment.
MIT License
277 stars 58 forks source link

Replace deprecated template_file with filetemplate #6

Closed thehackerish closed 2 years ago

thehackerish commented 2 years ago

The old way did not work when terraform was run from a windows machine, the yml files were not created. Plus, CRLF were printed as-is in the yml files when run the commands manually. Finally, the template_file is deprecated. Therefore, I am implementing local_file with templatefile to solve those issues in one go.

chvancooten commented 2 years ago

Thanks @thehackerish, this looks great! Code is much cleaner now, and solves your issues in a nice way. I was unaware of the local_file and templatefile features, good to know!

thehackerish commented 2 years ago

My pleasure, thanks for the awesome project! It deserves more contributions.