search

chvancooten / NimPlant

A light-weight first-stage C2 implant written in Nim.
MIT License
779 stars 109 forks source link

fix mingw flags for default Nim installation on ArchLinux #18

Closed tothi closed 1 year ago

tothi commented 1 year ago

This config tweak was needed on Arch, idk if it is needed elsewhere, but probably won't harm.

chvancooten commented 1 year ago

Thanks for the PR! Itś not immediately apparent to me what impact this may have on other builds, it looks fairly benign. if the CI/CD builds pass I'll do some manual checks and let you know!

tothi commented 1 year ago

Ok, thanks. Now I am a little bit uncertain whether this should be added to the build or not, because the issue is a Nim+Mingw issue, not related strictly to Nimplant (and affects only Arch as I know currently). If you have also doubts, probably a note about this in the README is a better solution (with a link to e.g. this: https://gist.github.com/tothi/1f452e0466070db5921135ab312749fc )

chvancooten commented 1 year ago

Thanks! I agree with that idea, though the builds seem to be passing I can't tell entirely what these configurations may do on other systems and it's not immediately related to Nimplant anyways. Closing this PR but I added a note to the readme, with the gist you shared and a word of credit :) Thanks again!

tothi commented 1 year ago

awesome, thanks! :)