Allow dynamic connections to APNS

[adrienmo]

rationale :

APNs configurations are not available when starting the elixir project, but are instead saved in a database (e.g. MySQL). We want to be able to dynamically create a connections when the configurations become available. Furthermore we can add a new application configuration on the fly.

solution :

• add a new interface APNS.connect_pool(name, configuration)
• allow the pool configuration to use a certificate that is not stored in a file, using the :cert and :key properties of ssl_options instead of :certfile

[chvanikoff]

Good catch, well done! But please check my comment before I can merge it

[adrienmo]

pool_conf has not been accidentally removed, it is passed directly as init parameter of the worker

you can see the variable pool_conf being passed instead of simply the name :

• def start_link(pool_conf) do
• def init(pool_conf) do
• defp get_config(pool_conf) do

Indeed, if the configuration is dynamic, there is no global variable to read it from ! The only call to the pool global config is made in the APNS module

[chvanikoff]

Yes, I see now, sorry for my inadvertence. Thank you, I'll merge it. New release is on the way.

[adrienmo]

Thank you !

Maybe the documentation should be updated with the following code example:

[
    {:Certificate, certder, :not_encrypted},
    {key_type, keyder, :not_encrypted}
] = :public_key.pem_decode(cert)

pool_conf = [
    env: :prod,
    pool_size: 10,
    pool_max_overflow: 5,
    cert: certder,
    key: {key_type, keyder}
]

APNS.connect_pool(:pool_name, pool_conf)