chwiede / pyads

Beckhoff ADS implementation for python
MIT License
49 stars 14 forks source link

Catch select.error in _AsyncRead #18

Closed ccatterina closed 6 years ago

ccatterina commented 6 years ago

Hi @chwiede,

I get this error using pyads:

Nov 22 01:09:37 cazzolla python[17578]: Exception in thread Thread-49682:
Nov 22 01:09:37 cazzolla python[17578]: Traceback (most recent call last):
Nov 22 01:09:37 cazzolla python[17578]: File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
Nov 22 01:09:37 cazzolla python[17578]: # _sys) in case sys.stderr was redefined since the creation of
Nov 22 01:09:37 cazzolla python[17578]: File "/usr/lib/python2.7/threading.py", line 763, in run
Nov 22 01:09:37 cazzolla python[17578]: # happen when a daemon thread wakes up at an unfortunate
Nov 22 01:09:37 cazzolla python[17578]: File "/usr/local/lib/python2.7/dist-packages/pyads/adsclient.py", line 81, in _AsyncRead
Nov 22 01:09:37 cazzolla python[17578]: ready = select.select([self.Socket], [], [], 0.1)
Nov 22 01:09:37 cazzolla python[17578]: File "/usr/lib/python2.7/socket.py", line 224, in meth
Nov 22 01:09:37 cazzolla python[17578]: type = property(lambda self: self._sock.type, doc="the socket type")
Nov 22 01:09:37 cazzolla python[17578]: File "/usr/lib/python2.7/socket.py", line 170, in _dummy
Nov 22 01:09:37 cazzolla python[17578]: error: [Errno 9] Bad file descriptor

This patch should solve the issue.

chwiede commented 6 years ago

@ccatterina Would it be ok for you if i add you as collaborator?

ccatterina commented 6 years ago

Of course it's ok. thanks!