chxuan / vimplus

:rocket:An automatic configuration program for vim
https://github.com/chxuan/vimplus
MIT License
3.9k stars 1.13k forks source link

add for FreeBSD support #304

Closed ardinzh closed 3 years ago

chxuan commented 3 years ago

@ardinzh 你好,感谢你提交pr,我看了下,该pr除了增加支持freeBSD以外,还修改了其他内容,一个pr最好是针对于单一功能的

ardinzh commented 3 years ago

其它内容是指 1: #!/bin/bash -> #!/usr/bin/env /bash 这一行吗? 我的理由是: 在FreeBSD上,bash 的正常安装路径是 /usr/local/bin/bash,和正常的linux发布版安装路径 /bin/bash 不一样。 所以,从 env 来获取 bash 的执行文档是能同时照顾两边的方案。 请考虑一下。

chxuan notifications@github.com 于2020年10月25日周日 下午6:01写道:

@ardinzh https://github.com/ardinzh 你好,感谢你提交pr,我看了下,该pr除了增加支持freeBSD以外,还修改了其他内容,一个pr最好是针对于单一功能的

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chxuan/vimplus/pull/304#issuecomment-716121562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRC6JIZ7IOOH3VHMVDSL5DSMPZOVANCNFSM4R3TKPBA .

chxuan commented 3 years ago

@ardinzh 你不是还改了目录结构,减少Home的隐藏文件数量吗?

ardinzh commented 3 years ago

那些没有推过来呀. 是有这个计划, 还没有准备提过来.

chxuan notifications@github.com 于2020年10月28日周三 下午12:35写道:

@ardinzh https://github.com/ardinzh 你不是还改了目录结构,减少Home的隐藏文件数量吗?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chxuan/vimplus/pull/304#issuecomment-717689333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRC6JMBSM6GSTPIJMJCEX3SM6NP3ANCNFSM4R3TKPBA .