search

chxy95 / HDRTVNet

ICCV2021 - A New Journey from SDRTV to HDRTV.
MIT License
126 stars 22 forks source link

Ablout mask calculation #10

Closed yinnhao closed 2 years ago

yinnhao commented 2 years ago

Hi, thank you for your great work! I have some question about the mask calculation in highlight generation. As discribed in Figure 2 in your paper, the mask is computed from original SDR image, but I found it is computed from LE output in your code. So which one should we use? As I realized, the non-linear RGB value in HDR image is hardly more than 0.95.

https://github.com/chxy95/HDRTVNet/blob/41d63b58bb953a83fcd1666d77848945a261fb06/codes/data/LQGT_hallucination_dataset.py#L77

chxy95 commented 2 years ago

@hahahaprince Actually the mask is calculated from the original SDR image. I generete the masks of the input SDR images in mask_folder in advance then read the masks from the mask folder.

chxy95 commented 2 years ago

@hahahaprince It seems an error in the released version, I have just corrected it.

yinnhao commented 2 years ago

Okay, I get it. Thanks