nus-pe-bot
commented
2 years ago Team's Response
Based on the elaboration given in this issue, the application does its job of catching the exception of trying to add an invalid time. However, the editing of the data file as stated by the tP constraint should be done only by advanced users. We believe that this is extreme user behaviour as it is deliberately tampering with the storage file.
It is also stated in the DG that the file should not be tampered with.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Below are the reasons why I disagree with the team's response:
-
The User Guide did not indicate that users should not tamper with the file.
-
Based on the module's constraint, the file is
Constraint-Human-Editable-File, i.e. (advanced) users are allowed to edit the files. If this is the case, that means the team has violated this constraint as in their DG, they wrote "highly not advised to tamper this file". -
Suppose users are allowed to edit the file (as per the module constraint), it is possible for a user to edit / enter a wrong timing as shown above (
2500), and there has been no deliberate tampering except a typo. The team should ensure that each field being entered into the FlightControl from the storage file is properly validated, similar to entering it from the command line.
Hence, with the above justifications, I'm unable to accept the team's rejection for this bug caught.
It is mentioned in the user guide and in the application it was also handled that when the time is out of the 24 hour range, it will not be accepted. I attempted to try to add outside of the 24H format in the application itself and it did not allow as well.
However, I modified the storage file for the departure time and it allowed me to go through.