replace linked_hash_map with hashlink

chyh1990 / yaml-rust

A pure rust YAML implementation.

Apache License 2.0

601 stars 138 forks source link

replace linked_hash_map with hashlink #157

Closed ghost closed 7 months ago

ghost commented 4 years ago

cc https://github.com/contain-rs/linked-hash-map/issues/97

chyh1990 commented 4 years ago

it seems that linked-hash-map is quite stable (and used by several popular crates), and we have no reason the switch to a new crate.

niluxv commented 4 years ago

linked-hash-map triggers UB (detected by miri). See the issue you linked and this issue at rustbreak(which has linked-hash-map only as a transitive dependency through this crate and serde_yaml and already triggers UB in the testsuite).

dessalines commented 3 years ago

Since linked_hash_map is broken on rust 1.48.0, and this is affecting downstream projects, this is pressing.

dessalines commented 3 years ago

Any movement on this? This has been preventing projects from using newer rust versions for 2 months now.