search

chyh1990 / yaml-rust

A pure rust YAML implementation.
Apache License 2.0
601 stars 138 forks source link

testing: add an integration test for yaml-test-suite #187

Open tanriol opened 2 years ago

tanriol commented 2 years ago

The official YAML test suite (https://github.com/yaml/yaml-test-suite). Requires the submodule to be checked out.

This is a draft PR because there's quite a number of failures. At the moment I'm seeing 62 unexpected errors (and 19 more errors where yaml-rust Event / Parser / EventReceiver API does not provide enough information about the document). I can mark the other errors as expected errors for now, but want to look at them first to check whether they're yaml-rust errors or some mistakes in this test harness.

perlpunk commented 2 years ago

I would like to mention that I added yaml-rust to the test matrix: https://matrix.yaml.info/ with the help of @tanriol

tanriol commented 2 years ago

@chyh1990 / @dtolnay Sorry for pinging directly, but I've seen no reaction to this PR yet. Should I continue trying to contribute to this repository, or should I instead fork the crate completely and work on improving it in my own fork?

neithernut commented 2 years ago

Well, according to @chyh1990's profile, their last activity was on June 3, 2020. But even before that, the activity was rather sparse. PRs and issues just kept accumulating without any meaningful progress for years now.

Maybe there are more active forks already?

dtolnay commented 2 years ago

I am not involved in this crate, since it is no longer used by serde_yaml.

tanriol commented 2 years ago

I am not involved in this crate, since it is no longer used by serde_yaml.

Sounds reasonable given the maintenance state of this crate. I'm leaving this PR open just in case, but don't really care about its fate in this case.

davvid commented 7 months ago

FWIW I have a fork I'm maintaining since I need this to keep working for the long-haul: https://github.com/davvid/yaml-rust/

I'd be happy to take PRs related to this topic there.