chyiiiiiiiiiiii / flutter_zendesk_messaging

Zendesk-Messaging for Flutter developer
Apache License 2.0
31 stars 47 forks source link

Android build fails due to missing namespace #58

Closed maxlapides closed 2 months ago

maxlapides commented 2 months ago

This issue occurs on 2.9.0, but not 2.8.0. I suspect it is related to this code change: https://github.com/chyiiiiiiiiiiii/flutter_zendesk_messaging/commit/88d086473f570d7f96aef81e2719bebfdaf0538b#diff-197b190e4a3512994d2cebed8aff5479ff88e136b8cc7a4b148ec9c3945bd65aL29-L32

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':zendesk_messaging'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file: /home/runner/.pub-cache/hosted/pub.dev/zendesk_messaging-2.9.0/android/build.gradle. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.
chyiiiiiiiiiiii commented 2 months ago

Thanks. I think it does not appear in every project. But the new version v2.9.1 has recovered for setting.

maxlapides commented 2 months ago

Looks good in 2.9.1. Thank you @chyiiiiiiiiiiii!