search

chylex / Better-Controls

Minecraft mod that adds many new options & keybindings for sprinting, sneaking, and flying. Supports Fabric & Forge.
https://www.curseforge.com/minecraft/mc-mods/better-controls
Mozilla Public License 2.0
5 stars 4 forks source link

Please add a config to disable menu button #24

Closed Xetaxheb closed 1 year ago

Xetaxheb commented 1 year ago

It would be great to have a config toggle to outright disable the menu button.

chylex commented 1 year ago

What is the reason for this request? I prefer to not add features "just because", so if there is a problem with the button I would rather fix that instead of working around it with new options.

Xetaxheb commented 1 year ago

Because there's any number of other mods that can get interfered with, or interfere with, the button being there; especially ones designed for that menu specifically. It's far more convenient to access the config menu through normal "Mod Options" or through a hotkey. And if nothing else, some people just don't like having the extra clutter in that menu for whatever personal reasons. It is also pretty standard practice for mods that add buttons to the main menu or escape or options guis to have an option to disable their additions/changes. You can look at quark, create, midnightcontrols, the list goes on and on.

But yes specifically this issue was created in response to it chronically overlapping something else, what exactly escapes me at the moment, but personally I really dislike extra menu gui changes where it's unnecessary anyway. I stopped using better-controls for this reason. Even if it's just a manually edited config entry of "show-button=true/false" to not render the button, that would be sufficient.

chylex commented 1 year ago

The button is positioned automatically based on other buttons in the menu, specifically so that it doesn't interfere with other mods' buttons or vanilla buttons that get added in updates.

Because there's any number of other mods that can get interfered with, or interfere with, the button being there

If other mods don't position the button automatically in the same way Better Controls does, then all of those mods will be incompatible with each other (and also with Better Controls if those mods happen to add their button to a fixed position after Better Controls does).

If there is an issue specifically with Better Controls' button positioning logic, and it interferes with another mod that also tries to not interfere with others, that can get fixed. If other mods add their own button on top of Better Controls' button because they don't check if that place is empty, that's not my problem.