search

chylex / IntelliJ-Inspection-Lens

IntelliJ platform plugin that shows errors, warnings, and other inspection highlights inline.
https://plugins.jetbrains.com/plugin/19678-inspection-lens
Mozilla Public License 2.0
57 stars 12 forks source link

Color configuration #19

Open synopss opened 1 year ago

synopss commented 1 year ago

The idea is to start creating configuration for the plugin. Best way to start : Color customization.

I've worked on a poc already, it will need to rethink the color system by using TextAttributesKeys configurable with xml files.

image

For now, nothing is linked to the plugin, it's just some UI work. See : https://github.com/synopss/IntelliJ-Inspection-Lens/tree/feat/settings

rlnt commented 1 year ago

Having the option to disable the background color would be a good start. The easiest solution is probably to inherit some already existing color settings but I think a standalone color setting for the plugin would be better in case you want to have different colors for actual warnings within the code.

synopss commented 1 year ago

Disable the background color would be possible with the solution above, you can just uncheck it, which will remove it. And since every gravity is handled separately, you will be able to combine some errors with background color and other without.

Also, I am not sure to understand your second point, can you elaborate more ?

chylex commented 1 year ago

I thought about it and with the background line colors I made the call to not add customization, primarily because every single thing that's in this plugin becomes my responsibility to not only test - which gets tricky with customization options - but also be expected to maintain basically forever... so for now, any customization is probably best left for a community fork.

synopss commented 1 year ago

Understandable, I'll stop there then. I'll keep the fork open so you change your mind, you'll have some kind of basis if you need one.

rlnt commented 1 year ago

Forget what I said synopss. But I'd really like to use your fork with the customization option then. Would you publish a release on it so I don't have to build it myself? :)