search

ci-reporter / ci_reporter

CI::Reporter is an add-on to popular test frameworks that allows you to generate XML reports
MIT License
343 stars 110 forks source link

check for refactored RSpec backtrace formatters and use the new method signature #76

Closed pivotal-chorus closed 11 years ago

DFrenkel commented 11 years ago

+1 - please accept this! Without this fix, spec failures result in an exception and the rest of the specs don't get a chance to run

DFrenkel commented 11 years ago

Gregg - I would try to extend the tests, though. Currently, they won't catch what you are fixing because formatter is set up as a mock without any parameter expectations for the format_backtrace method here: 

@formatter = mock "formatter"
@formatter.should_receive(:format_backtrace).and_return("backtrace")

If instead, we defined a stronger expectations on should_receive (it would also require to set up an expectation for example.metadata), we would be testing the right thing.

kamilio commented 11 years ago

+1

derfred commented 11 years ago

I'm seeing the same issue here.

johnnaegle commented 11 years ago

+1, same issue here, fixed by the pull request

derfred commented 11 years ago

It seems that this change adapted to a regression in RSpec 2.12.0 which has been fixed in 2.12.1 see https://github.com/rspec/rspec-core/commit/f06254c00770387e3a8a2efbdbc973035c217f6a

So now the opposite error occurs, see also #80.

Could you revert the change again?