LoadError for rspec/version for apps that use rspec-rails

DFrenkel commented 11 years ago

Fix for ci_reporter-1.8.2/lib/ci/reporter/rspec.rb:19:in `require': no such file to load -- rspec/version (LoadError) when using rspec-rails. Instead of using 'rspec/version', we should be using 'rspec/core/version'. For apps that use vanilla rspec, that also exists and will work just fine. However, for apps that use rspec-rails, rspec/version does not exist. It is probably a mistake by rspec to have version.rb in both rspec and in rspec-core as it introduces unnecessary confusion that causes this issue.

nicksieger commented 11 years ago

Thanks!

DFrenkel commented 11 years ago

Glad to help!

mrooney commented 11 years ago

Would it be possible to release this? Unless I'm missing something (very possible) it didn't make it into 1.8.3 (https://github.com/nicksieger/ci_reporter/blob/f59cbf16cd6f908964abebce2e5f81bd35d60fc8/lib/ci/reporter/rspec.rb) so we're still seeing this. Thanks for any help!

tchak commented 11 years ago

same here, 1.8.3 did not fix the problem

nicksieger commented 11 years ago

Sorry guys! 1.8.4 is released now.

ci-reporter / ci_reporter