search

ci-richard-mcelhinney / nhaystack

Niagara module for Project Haystack
https://www.project-haystack.org
Academic Free License v3.0
36 stars 23 forks source link

Question: Release planned to include "Added checks for retrieving number facets in case of bad config"? #42

Open tblong opened 7 months ago

tblong commented 7 months ago

Specifically interested if there is a release planned to include this commit: https://github.com/ci-richard-mcelhinney/nhaystack/commit/ec59e604115f03533657c6f1426d9e0a10f464d0

ci-richard-mcelhinney commented 7 months ago

Hi @tblong ,

As an open source project the code is available for anyone to build. Having said that it has been a while since I did a new build so I should do one soon. I'll try to get one out.

The tricky part is testing it on different versions of Niagara. So if you can help with that it would be appreciated.

tblong commented 7 months ago

As an open source project the code is available for anyone to build

Understood completely. If given access to the code signing cert and write permissions to this repo I would help with compiling, testing, and publishing the release build myself.

I have access to all presently supported versions of Niagara, so v4.10, 4.12, and 4.13. If you have an idea of what bugs, features, commits should be tested manually then happy to do so.

ci-richard-mcelhinney commented 7 months ago

@tblong you don't need the official signing cert to produce your own build. You can use a self-signed cert or buy your own code signing certificate. All the certificate does is certify that whoever built the code stands by the code.

I appreciate your offer of testing and I'll take you up on that, perhaps we can communicate offline for this. Mostly the testing between different versions is just sanity testing that it boots up and generally works as expected in each version. I'd like to get to the point of being able to document tests, perhaps we can work on this together. I'll make an effort to do a build and lets take it from there.

tblong commented 7 months ago

You can use a self-signed cert or buy your own code signing certificate. All the certificate does is certify that whoever built the code stands by the code.

Yes, though it would not be an official build from this repo's cert and then the community would end up not benefitting. I could fork then sign with our own cert, however that would just further fragment this work and cause confusion for end users over who's published version should be used.

Good to take this offline and help document any part of the manual testing steps taken.

tblong commented 6 months ago

Hey @ci-richard-mcelhinney, still happy to help test here. Let me know how you might like to take this offline.