search

ci-richard-mcelhinney / nhaystack

Niagara module for Project Haystack
https://www.project-haystack.org
Academic Free License v3.0
36 stars 23 forks source link

add support for BEnumOverride parameter for override action invocation - issue #44 #45

Open naimakov opened 3 months ago

naimakov commented 3 months ago

A numeric ordinal or string tag values are allowed in the invokeAction request

ci-richard-mcelhinney commented 2 months ago

@naimakov did you see my comments on your PR? Can you either update or provide some responses please?

naimakov commented 2 months ago

Yes, I can add some tests

naimakov commented 2 months ago

Thank you for your review and valuable feedback, @ci-richard-mcelhinney. I'll take feedback and modify the PR

ci-richard-mcelhinney commented 2 months ago

@naimakov no problem. I will review any updated code as soon as you post it.

Thanks, Richard

ci-richard-mcelhinney commented 1 month ago

@naimakov have you provided any updates yet for me to review?

naimakov commented 1 month ago

@naimakov have you provided any updates yet for me to review?

@ci-richard-mcelhinney hi, sorry for the long wait.

I refactored action argument iteration and added checks against invalid args

naimakov commented 1 month ago

@ci-richard-mcelhinney I'm adding unit tests, let me come back to you later today.

naimakov commented 1 month ago

@ci-richard-mcelhinney thank you for valuable feedback and patience. I've added modifications and unit tests for the changes proposed.

naimakov commented 1 day ago

Hi, @ci-richard-mcelhinney. I wanted to follow up on my previous comment. Would you be able to review PR changes I made please? Thank you.