search

ci010 / electron-vue-next

A starter template for using vue-next with the electron.
https://ci010.github.io/electron-vue-next/
191 stars 27 forks source link

Validation workflow simplified #17

Closed cawa-93 closed 3 years ago

cawa-93 commented 3 years ago

This removes dependence on third-party action and makes the workflow clearer and easier to change.

ci010 commented 3 years ago

I just noticed that the validation is broken... The action is better on that it can display the error in PR. Maybe I'll fork that action and fix it later. Thanks to fix!

cawa-93 commented 3 years ago

@ci010 When I see the script "lint" in the package.json, I expect that this command will run in the cloud. I expect that I can change this script somehow, use a different linter and these changes will be picked up in the workflow. Therefore, if you use the action, it should not be tied to a specific liner. Otherwise it is not very intuitive