cia-labs / Storage-service

General purpose storage service
GNU General Public License v3.0
10 stars 5 forks source link

Added Requirements.txt and Fixed Tests #26

Closed noobed-max closed 8 months ago

noobed-max commented 9 months ago
Ashish9738 commented 9 months ago

I think yeah, we have to add sqlite3, pydantic, requests to it. Other than that it LGTM and shutil, os, string, random are provide by default in python so i don't think so we should add by default.

noobed-max commented 9 months ago

hey so the thing is shutil is standard library of python and the sqlite3 i did look out for it too but according to https://stackoverflow.com/questions/19530974/how-can-i-add-the-sqlite3-module-to-python , as well as i wasnt able to find any package of sqlite3 so turns out even thats a built in package of python and as we are just performing basic operations the python package covers that up

Tejas-ChandraShekarRaju commented 9 months ago

@noobed-max can you update the PR as @Ashish9738 suggested. ? Before this @Ashish9738 clone the project in seperate folder and see if it starts running just after doing pip install requirements.txt. If yes acknowledge here and I will approve if not suggest the changes.

noobed-max commented 9 months ago

Yes we can , as the requirements.txt is part of server we don't require requests in it , and sqlite3 can be skipped don't want to mess with python standard libraries with other same libraries except for that we everything is good to go

Tejas-ChandraShekarRaju commented 9 months ago

Yes we can , as the requirements.txt is part of server we don't require requests in it , and sqlite3 can be skipped don't want to mess with python standard libraries with other same libraries except for that we everything is good to go

In that case. Let @Ashish9738 test the scenario I mentioned. If it starts without a hassle I will approve it and you can merge.

Ashish9738 commented 9 months ago

Add pytest in requirments, other than everything LGTM and also I think modification of ReadMe has to be done to install requirments.