search

ciaa / firmware_v1

Firmware de la CIAA
http://www.proyecto-ciaa.com.ar
126 stars 120 forks source link

#423 lwip arch directories for CIAA's arch #427

Closed mabeett closed 7 years ago

mabeett commented 8 years ago

with this change the arch files are just compiled for lpc4337 boards. There are also error messages in makefiles and cc.h source files inviting the user to participate

mabeett commented 8 years ago

feel free to ask or suggest any consideration in the changes. I do not merge my owns PRs since I consider that being who proposes I cannot be objective in the appreciation.

mcerdeiro commented 7 years ago

Hi @mabeett

I know is a long time ago... but after mergin https://github.com/ciaa/Firmware/pull/428 we have to merge this change manually. could you please update your repo as in step 1. You can also push to a new branch and then we can compare in github.

Thanks and sorry for the long delay :(

Thanks Mariano.-

mabeett commented 7 years ago

I know is a long time ago... but after mergin #428 we have to merge this change manually. could you please update your repo as in step 1.

There is no problem, #428 included the patch of this PR. So appling #428 this patch was applied. Maybe accepting (or not) older PR first this situation could be avoided.

Thanks and sorry for the long delay :(

;)

Thanks Mariano.-

Thanks you so much!