search

ciampo / macro-carousel

Carousel as a Vanilla Web Component.
https://ciampo.github.io/macro-carousel/demo/
MIT License
77 stars 6 forks source link

Buggy aria-hidden behaviour #43

Open pimdewit opened 5 years ago

pimdewit commented 5 years ago

In the demos, aria-hidden is almost always true, which of course is intended for slides that are not currently in the view. But it also happens on the selected slide.

It seems the only way for aria-hidden to apply correctly is by selecting a slide, trigger the mouse/touchdown event, and release again (demo below)

macro-aria

ciampo commented 5 years ago

Hey Pim,

Can you try to see if you can reproduce the bug on the commit tagged with version 1.0.0?

It may make it easier to track where the bug is coming from

Thank you!

On Mon, 16 Sep 2019 at 21:28, Pim de Wit notifications@github.com wrote:

In the demos, aria-hidden is almost always true, which of course is intended for slides that are not currently in the view. But it also happens on the selected slide.

It seems the only way for aria-hidden to apply correctly is by selecting a slide, trigger the mouse/touchdown event, and release again (demo below)

[image: macro-aria] https://user-images.githubusercontent.com/1285982/64961808-2a692400-d88e-11e9-9bf0-8716f476fbd4.gif

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ciampo/macro-carousel/issues/43?email_source=notifications&email_token=AAIIRPJ2A2TBWGRUGAWWEJ3QJ6CXHA5CNFSM4IXCIFRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLSTGZQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIIRPPCNN4AIL7KS3GWOVLQJ6CXHANCNFSM4IXCIFRA .