ciampo / macro-carousel

Carousel as a Vanilla Web Component.
https://ciampo.github.io/macro-carousel/demo/
MIT License
77 stars 6 forks source link

feat(slidesInView): separation of concerns + added method to public api #51

Open pimdewit opened 4 years ago

pimdewit commented 4 years ago

I thought slidesInView would be a nice addition to the public API, it is also a nice opportunity for separation of concerns. I extracted the snippet from _updateSlidesA11y and added it to its own getter.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 68


Files with Coverage Reduction New Missed Lines %
dist/macro-carousel-test.js 31 90.21%
<!-- Total: 31 -->
Totals Coverage Status
Change from base Build 62: -0.7%
Covered Lines: 539
Relevant Lines: 578

💛 - Coveralls