feat(PointerEvents): using PointerEvents instead of Mouse/TouchEvents

ciampo / macro-carousel

Carousel as a Vanilla Web Component.

https://ciampo.github.io/macro-carousel/demo/

MIT License

77 stars 6 forks source link

feat(PointerEvents): using PointerEvents instead of Mouse/TouchEvents #52

Open pimdewit opened 4 years ago

pimdewit commented 4 years ago

https://github.com/ciampo/macro-carousel/issues/6

Replaced Mouse/TouchEvents events with PointerEvents
removed normalizeEvent utility method (now redundant)
updated docstrings, removed NormalisedPointerEvent type definition

TODO:

Find a way to use pointer events in the current testing setup; tests fail because simulant does not recognise PointerEvents

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 67

0 of 0 changed or added relevant lines in 0 files are covered.
114 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-14.5%) to 76.402%

Files with Coverage Reduction	New Missed Lines	%
dist/macro-carousel-test.js	114	76.4%
<!--	Total:	114		-->

Totals
Change from base Build 62:	-14.5%
Covered Lines:	440
Relevant Lines:	562

💛 - Coveralls

ciampo commented 4 years ago

I remember writing tests for that part (and using simulant), it was quite tricky.

Also, if we go for native pointer events, we will need to add the polyfill (given the browser support) at least to the demos. And write documentation about it