Draft state after submit for review - FIXED

cianru / huawei-appgallery-publish-gradle-plugin

Huawei AppGallery Publish Gradle Plugin allows you to publish the android release build file (*.apk or *.aab) to the Huawei AppGallery store

Apache License 2.0

113 stars 20 forks source link

Closed ferPrieto closed 3 years ago

ferPrieto commented 3 years ago

There was a missing step. After submitting the app for review, the response should have been checked. In case the response had the below parameters:

CODE: 204144660
MSG contained It may take 2-5 minutes The 'submit for review' call had to be attempted again after 2-5 mins, and show the result right after. This is how the AppGalleryConnect API works.

I've had to remove the lazy stuff in the HuaweiPublishTask.kt otherwise the new code was never reached.

ferPrieto commented 3 years ago

By the way, successfully tested with one of my apps in production 👍

ferPrieto commented 3 years ago

:warning:Just as a reminder, this needs a CODE REVIEW asap :warning:

cosic commented 3 years ago

@ferPrieto Please move PR to develop target branch instead of master. See https://github.com/cianru/huawei-publish-gradle-plugin/blob/master/CONTRIBUTING.md I will build a snapshot for you.

ferPrieto commented 3 years ago

The PR points to Develop, please let me know whenever that snapshot is available 😄

cosic commented 3 years ago

@ferPrieto I'm going to merge you PR and build a snapshot. But should I expect a new PR with edits from you?

cosic commented 3 years ago

@ferPrieto I published 1.2.3-SNAPSHOT with you changes.