search

cianru / huawei-appgallery-publish-gradle-plugin

Huawei AppGallery Publish Gradle Plugin allows you to publish the android release build file (*.apk or *.aab) to the Huawei AppGallery store
Apache License 2.0
111 stars 20 forks source link

[1.3.0] Fix groovy sample config #31

Closed doodeec closed 3 years ago

doodeec commented 3 years ago

fixes groovy sample https://github.com/cianru/huawei-publish-gradle-plugin/pull/28#issuecomment-895572114 and possibly also #29 Aligns the config with kotlin sample

cosic commented 3 years ago

@doodeec Hi. I checked you previous PR and it fixed the sample-groovy build. Thx!

@ dusanbartos Actually with 2 samples in repo I was going to show and test next cases:

So I'm going to decline this PR coz the same plugin usage already has in the sample-kotlin.

doodeec commented 3 years ago

@doodeec Hi. I checked you previous PR and it fixed the sample-groovy build. Thx!

That's actually very interesting to hear, because the PR did not do anything with the groovy sample. Are you sure it's the thing what fixed it, and it was not fixed by some sideaffect (clean cache or other local changes)?

sample-kotllin: adding of plugin for build types and declarative plugin usage (plugins {}) sample-groovy: adding of plugin for build variants and imperative plugin usage (apply: )

ok no problem... maybe a small suggestion - if you plan to ship examples in the same repository as the plugin, keeping all in separate projects (instead of modules) would help with sync problems as happened here - if you have the plugin as a separate project, building it does not depend on all the samples being correctly configured

see https://github.com/android/gradle-recipes for reference

cosic commented 3 years ago

Are you sure it's the thing what fixed it, and it was not fixed by some sideaffect (clean cache or other local changes)?

Not sure. I can't reprodure anymore, so it could be cache.

see https://github.com/android/gradle-recipes for reference

Thx, I'll see that.