cianru / huawei-appgallery-publish-gradle-plugin

Huawei AppGallery Publish Gradle Plugin allows you to publish the android release build file (*.apk or *.aab) to the Huawei AppGallery store
Apache License 2.0
113 stars 20 forks source link

Releases Notes object dint update New Features in App Information #44

Closed Maxwell6635 closed 1 year ago

Maxwell6635 commented 1 year ago

When we execute upload the build together releases notes object, but in store dint see the releases notes is updated in App Information

Screenshot 2022-12-27 at 5 25 24 PM
Setup : 
huaweiPublish {
    instances {
        stagingRelease {
            credentialsPath = "$rootDir/huawei-credentials.json"
            deployType = "publish"
            buildFormat = "apk"
            releaseTime = "2023-12-30T09:00:00+0800"
            releaseNotes = [
                    new ru.cian.huawei.publish.ReleaseNote(
                            "en-GB",
                            "$projectDir/release-notes-en.txt"
                    )
            ]
        }
}

Command : ./gradlew assembleStagingRelease publishHuaweiAppGalleryStagingRelease

cosic commented 1 year ago

@Maxwell6635 Hi. As a see there is inaccuracy in the specified data. You set "en-GB" in plugin settings but your screenshot shows "English (US) - default" description page. See correct languases on this page

I guess you need to change or add a new one language

huaweiPublish {
    instances {
        stagingRelease {
            credentialsPath = "$rootDir/huawei-credentials.json"
            deployType = "publish"
            buildFormat = "apk"
            releaseTime = "2023-12-30T09:00:00+0800"
            releaseNotes = [
                    new ru.cian.huawei.publish.ReleaseNote(
                            "en-US",
                            "$projectDir/release-notes-en.txt"
                    ),
                    new ru.cian.huawei.publish.ReleaseNote(
                            "en-GB",
                            "$projectDir/release-notes-en.txt"
                    )
            ]
        }
}
Maxwell6635 commented 1 year ago

@cosic Ah I see thanks for helping again. :)

rtsisyk commented 1 year ago

@cosic thanks for adding support for release-notes. It works like a charm.

https://github.com/organicmaps/organicmaps/pull/4350#issuecomment-1407345589

It would be better to support Triple-T structure, but I have solved this issue by this small Groovy snippet below:

https://github.com/organicmaps/organicmaps/blob/93799b6977d761534c2e1bc043c15f9148aeebbb/android/build.gradle#L462-L480

Do you have any plans to add support for appname, title, description?

cosic commented 1 year ago

Hi, @rtsisyk

@cosic thanks for adding support for release-notes. It works like a charm. https://github.com/organicmaps/organicmaps/pull/4350#issuecomment-1407345589

Thanks. Glad to hear that.

It would be better to support Triple-T structure, ...

I guess we've already discussed this issue with your collegue https://github.com/cianru/huawei-appgallery-publish-gradle-plugin/issues/37#issuecomment-1250874835. I still think that it's not a good idea to have a strong relations to other project. Instead I've created a flexible options of mine Release Notes decision to support any configuration.

...but I have solved this issue by this small Groovy snippet below: https://github.com/organicmaps/organicmaps/blob/93799b6977d761534c2e1bc043c15f9148aeebbb/android/build.gradle#L462-L480

Thanks a lot. I guess I will add your solution somewhere as example.

Do you have any plans to add support for appname, title, description?

Unfortunatеly the Huawei Publishing API doen't have oportuneties to change appname, title and description. But if you would like to change Basic App Info you can. See appBasicInfo the Plugin parameter description.