search

cianru / presto-kafka-emitter

Presto query events logging to kafka
6 stars 5 forks source link

Would you like to contribute this to prestosql as part of kafka plugin? #2

Open kokosing opened 3 years ago

kokosing commented 3 years ago

This project seems to bring great value. Having this as part of PrestoSql project would make sure it would be widely used and maintained by vibrant Presto community.

What do you think?

drowoseque commented 3 years ago

Hey @kokosing I don't think this logging plugin should be embedded into the Kafka plugin, which is responsible for reading data

kokosing commented 3 years ago

Notice that Presto plugin may provide many features. You don't have to have a single plugin per feature (like connector or event listener).

Having this separate, we will possibly end up with another presto and kafka related library that would be used by two separate Kafka plugins in Presto. Having this both in one place is much easier.

Additionally, notice io.prestosql.spi.connector.Connector#getEventListeners. So could possibly configure kafka plugin to provide both features to Presto at once.