search

ciao-project / ciao

Ciao - Cloud Integrated Advanced Orchestrator
Apache License 2.0
215 stars 51 forks source link

ciao-vendor: Checkout default branch of $GOPATH dependency after vendoring #267

Open markdryan opened 8 years ago

markdryan commented 8 years ago

Currently, when vendoring, ciao-vendor checkouts of the version of the package you wish to vendor under $GOPATH. Once vendoring is complete it iterates through all the dependencies under $GOPATH it just vendored and checks out the master branch in this dependencies, i.e, tries to return the $GOPATH source tree to the state it was in before vendoring began. The problem we have right now is that not all git repos use master as their default branch. yaml.v2 for instances uses the v2 branch. Consequently, ciao-vendor needs to be changed to check out the default branch for each dependency after vendoring.

markdryan commented 7 years ago

There's probably no point in fixing this as we should move to dep soon.