search

ciaranm / detectindent

Vim script for automatically detecting indent settings
173 stars 48 forks source link

Ignore HTML/XML comment blocks #17

Open philbooth opened 11 years ago

philbooth commented 11 years ago

Hey Ciaran.

I made this change locally after experiencing the same problem as discussed in issue #12.

Obviously that thread is a year old and you made a strong argument against this change there, so I'm happy if you want to reject it. Just thought I should give you the opportunity to speak for yourself, rather than assuming rejection as a fait accompli! :)

ciaranm commented 11 years ago

I'm still sceptical that HTML comments are commonly formatted in a way that screws up indenting. And even if they are, should they be?

philbooth commented 11 years ago

...quite possibly not!

I only made the change so I could use vim on a legacy codebase in my new job. This pull request was made more in the interests of being a responsible open-source citizen (giving back) than because I feel strongly that the change should make it back into your repo. If you're against it, that's cool with me. :)