Closed Techn1x closed 3 years ago
Good news! In the month since opening this PR, our app had been updated from Ember 3.12 to 3.16. Turns out that was likely the cause of the issue here. I thought it was already on 3.16, but I was mistaken. Now everything works fine, including in IE11.
Silly me didn't see the Ember > 3.13
requirement in the readme and had been using EBD v2 with Ember 3.12 this whole time.
Sorry for contributing noise to the issues list - I do hope someone else finds this helpful though!
My 3.16 app has been running v2.0.13 for some time, tried to upgrade to v3 but having some problems. Once on any v3 version, the dropdown content no longer opens or appears
Tested a few versions;
Based on my research;
this.publicAPI.isOpen
is correctly read and successfully calls the correct open()/close()isOpen
to true or false, so that the next toggle() correctly reads a newthis.publicAPI.isOpen
value all good so farI added the following to the basic-dropdown.hbs template..
If I then follow the trail,
this.publicAPI.isOpen
is what is read in the content component, and https://github.com/cibernox/ember-basic-dropdown/blob/4596ed5475c47f90038dad44dd11c0dac6e34d12/addon/templates/components/basic-dropdown.hbs#L16 https://github.com/cibernox/ember-basic-dropdown/blob/4596ed5475c47f90038dad44dd11c0dac6e34d12/addon/templates/components/basic-dropdown-content.hbs#L2-L4 Sure enough, I always see the content-placeholder element, it's never replaced by the origin-wormhole element above. https://github.com/cibernox/ember-basic-dropdown/blob/4596ed5475c47f90038dad44dd11c0dac6e34d12/addon/templates/components/basic-dropdown-content.hbs#L33-L35I'm a little bit new to this glimmer stuff, but is there anything I could be missing as to why
this.publicAPI
andthis.publicAPI.isOpen
is never updated in the template?