cibernox / ember-basic-dropdown

The basic dropdown you ember app needs
http://www.ember-basic-dropdown.com
Other
156 stars 183 forks source link

convert to v2? #719

Closed betocantu93 closed 9 months ago

betocantu93 commented 11 months ago

Hello !! I'm wrapping ember-power-select, thus wrapper ember-basic-dropdown for ember-eui https://github.com/prysmex/ember-eui/tree/master/packages/core/addon/components/eui-combo-box

I'm working in migrating embr-eui to v2, which removes the ember-cli classic build pipeline, so no more contentFor etc

Most of these apis can be replaced by new paradigms.

On my v2 addon, as far as I know since I don't have contentFor anymore, https://github.com/prysmex/ember-eui/blob/3f2111a93c8afa11a1fad3623e33acefdcad68a5/packages/core/index.js#L55,

I need to add instructions like:

Please add in your index.html

<div id="ember-basic-dropdown-wormhole"></div>;

Which makes me want to migrate both ember-basic-dropdown and ember-power-select to new v2 SPEC and provide clear instructions on each package to how to do the stuff that the included and contentFor from both packages did in classic addons

mkszepp commented 11 months ago

Hi @betocantu93,

atm, this addon (and also other ember-power addon's) are not ready for using in an v2 addon.

The migration to v2 brings for this addon and also other a lot of braking changes. I have already analysed a little bit the migration for this addon and also other ember-power addons, but since now i havn't started the migration.

I'm sure, that there is time to migrated this and also other ember-power addons to v2.

My plan was, to make a release in the next days for ember-basic-dropdown & ember-power-select and than i think we can start to migrate to a v2 addon.

betocantu93 commented 11 months ago

Aight! Let me know if you need help. Thanks

mkszepp commented 10 months ago

@betocantu93 i think, i have now completely converted to v2 addon see PR (https://github.com/cibernox/ember-basic-dropdown/pull/728).

Also docs were updated for this changes...

In the next days i will prepare a beta release and than we need to do the same for ember-power-select and making tests with basic dropdown as v2 addon

betocantu93 commented 10 months ago

Wow! Nice, will have a look at it. Great job and thanks for working on this.

mkszepp commented 9 months ago

@betocantu93 sry for my delay... there is now released the addon as v2 addon (tag 8.0.0-beta.0) Also ember-power-select was migrated to a v2 addon and released with tag 8.0.0-beta.0

ember-basic-dropdown has now a component (<BasicDropdownWormhole />) which can be added in application.hbs or in an other place, see install documentation https://ember-basic-dropdown.com/docs/installation. This adds <div id="ember-basic-dropdown-wormhole"></div> like you have described

NullVoxPopuli commented 9 months ago

been testing the the beta.3/beta.2 of power-select/basic-dropdown, in an app with > 13k tests, and things are going smoothly.

mkszepp commented 9 months ago

@NullVoxPopuli thank you for feedback! The plan is to hold beta for next days. Maybe we get some additional feedbacks & hofully no bug reports 😅.