search

cibernox / ember-cli-yuidoc

EmberCLI addon for generate documentation from YUIDoc coments
MIT License
55 stars 25 forks source link

Run Y.Project.init only when Yuidoc is enabled #36

Closed simonihmig closed 8 years ago

simonihmig commented 8 years ago

Y.Project.init was always called (within optsGenerator.generate) even when yuidoc was not used.

The problem is the console.log output of yuidoc itself (outputs things like "Scanning for yuidoc.json file."): when running ember test in a CI environment with the --silent flag, capturing output to a xunit file (see https://ember-cli.com/testing#ci-mode-with-testem), the console output of yuidoc (obviously not affected by --silent) would still find its way into that file, breaking xml and thus the whole build.

The small change makes sure that init is only called when a yuidoc run is really needed.

cibernox commented 8 years ago

LGTM.

cibernox commented 8 years ago

Published in 0.8.5

simonihmig commented 8 years ago

Cool, thanks!