cibernox / ember-native-dom-helpers

Test helpers for your integration tests that fire native events
MIT License
186 stars 37 forks source link

Replaces usage of deprecated merge with assign #153

Closed SergeAstapov closed 5 years ago

SergeAstapov commented 5 years ago

Closes #152

SergeAstapov commented 5 years ago

We don't use this addon directly in our app as it's not needed with new-ish versions of ember-cli-qunit as stated in readme.

However ember-cli-page-object depends on it in order to provide native events and avoid jQuery usage.

Once this is merged, can we get new version bump?

SergeAstapov commented 5 years ago

@cibernox do you think this can be merged?

cibernox commented 5 years ago

Sorry for the delay, I missed this notification while on holidays and when I returned I declared backruptancy of github notifications. Merged.

I'll release a new version later

cibernox commented 5 years ago

Released.

SergeAstapov commented 5 years ago

Thank you @cibernox!