cibernox / ember-native-dom-helpers

Test helpers for your integration tests that fire native events
MIT License
186 stars 37 forks source link

Follow up on focus event helper function #9

Open pixelhandler opened 7 years ago

pixelhandler commented 7 years ago

@rwjblue there is one other point to chat about at some point too, the focus method in the existing test helpers has an issue with Firefox and focus on window or not. I was able to resolve that in this library as I added test running via Chrome, Firefox on Travis as well.

See…

https://github.com/cibernox/ember-native-dom-helpers/blob/master/addon-test-support/helpers.js#L11-L31

vs.

https://github.com/emberjs/ember.js/blob/7819409b7b6559e9fc0300a29e66a16356fb67a7/packages/ember-testing/lib/events.js#L8-L27

pixelhandler commented 7 years ago

Tests to investigate:

These tests failed for us when running on Firefox or phantomjs…

…the focus part was the issue

Test failure example, focus not firing when window does not have focus: