cibernox / ember-power-select-typeahead

Typeahead component built on top of ember-power-select
MIT License
37 stars 57 forks source link

ember-try fails running against ember >= 3.25 #106

Open jderr-mx opened 3 years ago

jderr-mx commented 3 years ago

In the course of trying to upgrade an ember app from 3.20 to 3.26 I am stuck on 3.24

Looking through my addons, I suspect it may be ember-power-select-typeahead

I know ember-basic-dropdown was updated recently to fix a similar issue with other power-select based addons

cibernox/ember-basic-dropdown#586

I ran ember-try against 3.25 and ember-release (currently 3.26) to see if it matched the build errors I was getting in my app.

Template Compiler Error (broccoli-persistent-filter:TemplateCompiler) in ember-basic-dropdown/templates/components/basic-dropdown-content.hbs

Cannot read property 'type' of undefined

npm ls ember-basic-dropdown output is

ember-power-select-typeahead@0.8.0 /Users/john/git/ember-power-select-typeahead └─┬ ember-power-select@3.0.3 └── ember-basic-dropdown@2.0.4

linearza commented 3 years ago

Running into this now as well - @jderr-mx did you ever find a solution?

├── ember-basic-dropdown@3.0.21
├─┬ ember-power-select@4.1.3
│ └── ember-basic-dropdown@3.0.21  deduped
└─┬ ember-power-select-typeahead@0.8.1
  └─┬ ember-power-select@3.0.6
    └── ember-basic-dropdown@2.0.15
jderr-mx commented 3 years ago

I have not found a complete solution.

I tried bumping these packages with diff

 -    "ember-cli": "~3.11.0",
 +    "ember-cli": "~3.25.0",
 -    "ember-resolver": "^4.0.0",
 -    "ember-source": "~3.11.1",
 +    "ember-resolver": "^8.0.0",
 +    "ember-source": "~3.25.1",
 -    "ember-power-select": "^3.0.3"
 +    "ember-power-select": "^4.1.6"

This got it most of the way there except for one failing test

not ok 11 Chrome 95.0 - [96 ms] - Integration | Component | <PowerSelectTypeahead>: The dropdown doesnt have a "button" role

linearza commented 3 years ago

Interesting, based on this conditional here https://github.com/cibernox/ember-power-select/blob/3a73a70293c721e6368a8ce293e2652869930342/addon/components/power-select.hbs#L46 - it seems like it wont ever pass with the existing logic.

It was originally added here https://github.com/cibernox/ember-power-select-typeahead/pull/85/files#diff-adc931b1a470914f227ab7df4b063eba2f6af56bd3ab6d98a2f1347840114c85R47 on 9 Aug 2019 but updated on ember-power-select on 18 Nov 2019 https://github.com/cibernox/ember-power-select/pull/1288/files#diff-0b703d8c10bb63b1c66c49b19f314eb7570932db57cd09b0fd2d811799d962a9R44 where it previously didnt default https://github.com/cibernox/ember-power-select/blame/d21e0f550a0f7965f75a5217b65fc2489719aff8/addon/templates/components/power-select.hbs#L22 - so I believe this test is no longer valid

linearza commented 3 years ago

Thank you for your insight around additional dep upgrades. Ive updated the related PR with it and disabled the test as per above https://github.com/cibernox/ember-power-select-typeahead/pull/114

linearza commented 3 years ago

@jderr-mx this has been merged and published to 0.8.2