cibernox / ember-power-select-typeahead

Typeahead component built on top of ember-power-select
MIT License
37 stars 57 forks source link

Upgrade ember-power-select to 5.0.4 #122

Open andrewcallahan opened 2 years ago

andrewcallahan commented 2 years ago

Hi @cibernox hope all is well!

I've run into some trouble running an ember app (version 4.4 - the current latest) with this addon due to an issue with conflicting ember-embroider versions. I was able to replicate this error by making a new ember app and adding both ember-power-select and ember-power-select-typeahead - which fails to build. I think the solution is to upgrade the ember-power-select version within ember-power-select-typeahead, which I've done in this PR. I silenced a few deprecations that were introduced but there are a few new deprecation warnings on the first test that I couldn't figure out how to solve. It may have something to do with a modifier element on ember-basic-dropdown but I'm not sure - a bit hard to debug.

Also while I ended up fixing 3 of the 5 failing scenarios in ember-try (ember-release, ember-beta and ember-canary), this PR now makes embroider-safe fail. Not sure how important this is but wanted to let you know.