search

cibernox / ember-power-select-typeahead

Typeahead component built on top of ember-power-select
MIT License
37 stars 57 forks source link

Add animationEnabled to pass it through power-select #77

Closed neeleshsaxena closed 5 years ago

neeleshsaxena commented 5 years ago

Need to pass in animationEnabled property through typeahead.

Been running into ember run loop errors related to animating dropdown when the component has already been destroyed, as it's scheduled afterRender here - https://github.com/cibernox/ember-basic-dropdown/blob/master/addon/components/basic-dropdown/content.js#L183

Will be creating another PR in ember-power-select to let this property pass down to ember-basic-dropdown.

cibernox commented 5 years ago

Thanks!

cibernox commented 5 years ago

I don't have time to make a release now, but ping if I by tomorrow I haven't.

neeleshsaxena commented 5 years ago

Sure. Thank you!

neeleshsaxena commented 5 years ago

@cibernox Can you please push a release whenever you can. Also over here - https://github.com/cibernox/ember-power-select/pull/1165

Have a defect right now related to performance in IE, which should get solved after this upgrade. Thanks!