search

cibernox / ember-power-select

The extensible select component built for ember.
http://www.ember-power-select.com
Other
540 stars 377 forks source link

Power Select is activated on touchmove #1011

Open SteAllan opened 6 years ago

SteAllan commented 6 years ago

On both iOS and Android, if you begin a touchmove event on a Power Select, the Power Select is focussed and, if it is a Power Select Multiple, it also opens its options list. This has the undesirable effect of opening the device's keyboard when scrolling a form, for example.

Experiencing this with v1.10.0 of ember-power-select on the latest iOS and Android 7.0.

cibernox commented 6 years ago

I'll try. Do you know if this was a regression in recent versions or it never worked? Because I think I had specific code to allow scrolling in touch devices without opening the select.

SteAllan commented 6 years ago

I first noticed the issue with an earlier version, possibly 1.8.x, certainly nothing older than 1.6.1.

cibernox commented 6 years ago

Ok, the only change I can think about that could have cause this was in 1.9.X, so I'll try to reproduce it

lupestro commented 6 years ago

Is this related to my getting the following when I trigger the drop-down on my touch-enabled PC? Added non-passive event listener to a scroll-blocking touchstart event. Consider marking event handler as 'passive' to make the page more responsive. Or should I open a separate issue for that? (Still running 1.10.4 for use with production code but eager for 2.0 to emerge from beta. :) )

cibernox commented 6 years ago

Verify in 2.0, but I don't expect it to have changed. I need to investigate if I can make those events passive, and if not, explicitly pass { passive: false } to remove the deprecation.